Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dynamic strings append to fixed strings issue #1346

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Fix dynamic strings append to fixed strings issue #1346

merged 3 commits into from
Feb 26, 2024

Commits on Feb 22, 2024

  1. Adds additional append empty tests 

    - Used to verify the refactor afterwards works with all cases
    @IvoDD
    IvoDD committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    0e539bf View commit details
    Browse the repository at this point in the history

  2. Adds a failing test to demonstrate #1349 

    - Will be fixed in a follow up commit in the same PR
    @IvoDD
    IvoDD committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    04be34d View commit details
    Browse the repository at this point in the history

  3. Abstract out building of a merged descriptor 

    - Deduplicates merging descriptors inside update and append
- Fixes fixed string to dynamic string conversion #1204
- Fixes inconsistent column ordering when appending #1349
    @IvoDD
    IvoDD committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    a55dbac View commit details
    Browse the repository at this point in the history