Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest-shutil: Replace deprecated imp module #219

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented May 27, 2023

Replace the use of the deprecated imp module with `importlib.util', as the former has been removed from Python 3.12.

Replace the use of the deprecated `imp` module with `importlib.util',
as the former has been removed from Python 3.12.
@wpbonelli
Copy link

If no further maintenance is planned (cf #214, #218) I'm wondering about re-homing pytest-virtualenv as a standalone project.

  • Would anyone be willing to contribute? @mgorny @JamesWrigley @kloczek @mayeut @abravalheri
  • Is ownership transfer an option? I would not like to take on this whole repo but may consider if others will help.
  • Is pytest-venv an alternative? It also seems unmaintained, maybe @mmerickel has insight
  • If a new project is needed, should it continue to use virtualenv or builtin venv?
  • Is PyPI ownership transfer possible, either pytest-virtualenv or pytest-venv? If not, what to name a new plugin?

@mmerickel
Copy link

mmerickel commented Nov 23, 2023

Is pytest-venv an alternative? It also seems unmaintained, maybe @mmerickel has insight

pytest-venv is not unmaintained, it's just going at the speed of free... :-) But yes, I'm not looking to change the scope of the library much past what it is right now. I did just release 0.3 with several improvements including Python 3.12 support. I'm not clear why pytest-venv is being pinged on this issue about pytest-shutil - I do not use pytest-shutil - but regardless hopefully this serves as my insight!

If a new project is needed, should it continue to use virtualenv or builtin venv?

Well pytest-venv uses virtualenv so that it can create virtualenvs with different versions of Python if desired. venv is limited to the interpreter executing the command. I do not see the problem with continuing to depend on virtualenv to create virtualenvs - it's a great library with more features than the builtin venv.

Copy link
Contributor

@jonbannister jonbannister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me, thank you for your contribution. Apologies for the long wait!

@jonbannister jonbannister merged commit 3340160 into man-group:master Oct 4, 2024
@mgorny
Copy link
Contributor Author

mgorny commented Oct 4, 2024

Thanks!

@mgorny mgorny deleted the shutil-imp branch October 4, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants