Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix refund on selfdestruct #126

Closed
vyorkin opened this issue Jun 1, 2018 · 0 comments · Fixed by #127
Closed

Fix refund on selfdestruct #126

vyorkin opened this issue Jun 1, 2018 · 0 comments · Fixed by #127
Assignees
@vyorkin
Labels
evm priority: high tag: bug fix
Milestone
Simple node (MVP)

Comments

@vyorkin
Copy link
Contributor

vyorkin commented Jun 1, 2018 •
edited
Loading

image

Consider creating a new "refund account" if it doesn't exist (it should be shadow-created if it receives eth, this is already implemented).

image

We need to transfer the balance of the "suicided" account to it.

May be related:
openethereum/parity-ethereum#4757
ethereum/EIPs#168
ethereum/EIPs#161
ethereum/EIPs#169

Resolving this issue should fix the push32AndSucide test (and maybe other failing "suicide" test too).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vyorkin vyorkin

Labels
evm priority: high tag: bug fix
Projects
None yet
Milestone
Simple node (MVP)
Development

Successfully merging a pull request may close this issue.

Fix EVM tests mana-ethereum/mana
1 participant
@vyorkin