Fix EVM tests #127
Fix EVM tests #127
Conversation
ghost
added
the
vyorkin
requested review from
ayrat555,
masonforest,
germsvel and
cernivec
and removed request for
ayrat555 and
masonforest
| {gas, sub_state, exec_env, _} = run_test(test) | ||
| assert_state(test, exec_env.account_interface) | ||
|
|
||
| context = %{ |
There was a problem hiding this comment.
I think this whole test needs to be refactored, just maybe not as part of this PR.
|
Thanks! I'll double check if I'm running all the EVM tests from the ethereum common tests & fix that. |
|
Ah, I see that @masonforest have created a separate issue to track this #124 so we're good. |
Rename suicide op to selfdetstruct according to EIP-6. Don't ignore empty state values in EVM tests. Transfer the balance of the self-destructed account to the "refund account" (its address is the top 20-bytes on VM's stack). Refund account is "shadow-created" if it doesn't exist. Refactor and fix the `evm_test.exs`: * Remove the `code` field from the caller's account (see http://ethereum-tests.readthedocs.io/en/latest/test_types/vm_tests.html#the-exec-section). * Exclude caller's account from the actual state if it isn't in the "pre" or "post" addresses. Update `EVM.Address.new` to use only the last `@size` of bytes for address construction: this is important because in VM operations we're getting addresses from the VM stack as integers that can be of any size. Replace the doctest for `SELFDESTRUCT` operation in `EVM.System` module with a regular ExUnit test. Slightly refactor and fix the `new_account` fn (add empty `code` field) in `EVM.Interface.Mock.MockAccountInterface` module. Fix `vm_test.exs` (add empty `code` field).
|
ok, rebased |
There was a problem hiding this comment.
The Yellow Paper says SELFDESTRUCT should Halt execution and register account for later deletion.
I think eventually we want SELFDESTRUCT to add the contracts address to the suicide_list and actually delete them when we're processing transactions. Does that sound right?
This PR looks good to go though. I'd rather have a passing test suite and refactor from there as needed.
|
@masonforest yes! its by mistake, thanks for pointing this out |
|
Ok, I'll merge this and refactor the |
Rename
suicideop toselfdestructaccording to EIP-6.Transfer the balance of the self-destructed account to the "refund account" (its address is the top 20-bytes on VM's stack). Refund account is "shadow-created" if it doesn't exist.
Refactor and fix the
evm_test.exs:codefield from the caller's account (see http://ethereum-tests.readthedocs.io/en/latest/test_types/vm_tests.html#the-exec-section).Update
EVM.Address.newto use only the last@sizeof bytes for address construction:this is important because in VM operations we're getting addresses from the VM stack as integers that can be of any size.
Replace the doctest for
SELFDESTRUCToperation inEVM.Systemmodule with a regular ExUnit test because it's getting quite complex.Added
:sendercondition to theEVM.Debugger.Breakpointfor convenience.Slightly refactor and fix the
new_accountfn (add emptycodefield) in theEVM.Interface.Mock.MockAccountInterfacemodule.Fix
vm_test.exs(add emptycodefield).resolves #126, resolves #109