-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include reference to function that contains a given bb in json doc #130
Comments
interesting point - when we have a BB match, should we report the address of the BB or the function? currently, we report the address of the BB. the BB address is more specific, and better corresponds to how capa is doing the matching. if nothing else, we should probably update the json document to include both. |
Nevermind, the output is correct (I thought BB address and offset are wrong). Including the function association in the JSON and potentially the output here makes sense to me though! |
not sure if we can hit this by 1.0/thursday, but its a non-breaking change to the JSON doc, so we can do this as we have time. |
this isn't super trivial, because we need to find a way to thread the association between bb and func all around. could maybe stuff it into the
|
so bb can be associated with function in output. only captures BBs that have a rule match, otherwise, there might be too much data captured. closes #130.
For basic block matches, we could tweak the output to include the function in which the BB is foun.d
The text was updated successfully, but these errors were encountered: