Fix 130 #813
Merged
Fix 130 #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so bb can be associated with function in output. only captures BBs that have a rule match, otherwise, there might be too much data captured. closes #130.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
github-actions
bot
dismissed
their stale review
CHANGELOG updated or no update needed, thanks! 😄
mike-hunhoff
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
wonderful! thank you for all your work again @williballenthin! LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
record the layout of basic blocks within functions to enable the display of the containing function when a BB-scoped rule matches. stores this in
.meta.analysis.layout.functions.0x401000.matched_basic_blocks = [0x401000, 0x401005, ...].only captures the basic blocks that have a match. this increases the JSON document size of k32 from 3.4 to 3.6MB; capturing all BBs results in a 3.9MB document.
closes #130
Checklist