Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dynamic analysis #1697

Merged
merged 556 commits into from
Nov 29, 2023
Merged

add dynamic analysis #1697

merged 556 commits into from
Nov 29, 2023

Conversation

williballenthin
Copy link
Collaborator

@williballenthin williballenthin commented Aug 10, 2023

This is a draft PR so that we can begin to review the whole set of changes that @yelhamer proposes to enable dynamic analysis in capa. I'm not sure if we'll merge from this PR or re-create one later that we keep a bit tidier.

For the time being, when a change needs a review, lets continue to open PRs against the branch dynamic-feature-extraction, not update this PR. Its ok to merge small "suggested changes" from here when little discussion is required.

TODO:

@williballenthin williballenthin added dont merge Indicate a PR that is still being worked on gsoc Work related to Google Summer of Code project. dynamic related to dynamic analysis flavor labels Aug 10, 2023
Copy link
Collaborator Author

@williballenthin williballenthin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i read through all 3,600 lines of changes. i didn't see any major architectural issues - that's great!

i added small items, suggested changes, and TODOs (via checklist items) inline here. please check and resolve so that we can track outstanding work here. major efforts ive added to the original PR comment text.

there are a lot of small things to tweak, though, perhaps two dozen things of 30 mins each to think about and implement.

.github/mypy/mypy.ini Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
.gitmodules Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
capa/features/address.py Outdated Show resolved Hide resolved
tests/test_main.py Outdated Show resolved Hide resolved
tests/test_main.py Outdated Show resolved Hide resolved
tests/test_result_document.py Outdated Show resolved Hide resolved
tests/test_scripts.py Outdated Show resolved Hide resolved
tests/test_static_freeze.py Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@williballenthin williballenthin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i read through all 3,600 lines of changes. i didn't see any major architectural issues - that's great!

i added small items, suggested changes, and TODOs (via checklist items) inline here. please check and resolve so that we can track outstanding work here. major efforts ive added to the original PR comment text.

there are a lot of small things to tweak, though, perhaps two dozen things of 30 mins each to think about and implement.

@williballenthin

This comment was marked as resolved.

@williballenthin williballenthin mentioned this pull request Aug 11, 2023
3 tasks
@williballenthin
Copy link
Collaborator Author

we should also see what the experience is like against a ransomware report with a million file read/writes.

mr-tz and others added 12 commits November 28, 2023 15:00
only check and display file limitation once
set os, arch, format in meta table
* README: adapt for dynamic capa

* README.md: fix duplication error

* Update README.md

Co-authored-by: Moritz <mr-tz@users.noreply.github.com>

* documentation: add review suggestions

* documentation: newline fix

* Update README.md

Co-authored-by: Moritz <mr-tz@users.noreply.github.com>

* Update README.md

Co-authored-by: Moritz <mr-tz@users.noreply.github.com>

* Update README.md

Co-authored-by: Moritz <mr-tz@users.noreply.github.com>

---------

Co-authored-by: Moritz <mr-tz@users.noreply.github.com>
Co-authored-by: Willi Ballenthin <willi.ballenthin@gmail.com>
@yelhamer yelhamer marked this pull request as ready for review November 29, 2023 16:14
@mr-tz mr-tz merged commit 4c3586b into master Nov 29, 2023
24 of 25 checks passed
@mr-tz mr-tz deleted the dynamic-feature-extraction branch November 29, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont merge Indicate a PR that is still being worked on dynamic related to dynamic analysis flavor gsoc Work related to Google Summer of Code project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants