update freeze for dynamic #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williballenthin
added
enhancement
williballenthin
changed the base branch from
master
to
dynamic-feature-extraction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the freeze implementation that supports dynamic analysis. The primary change is to keep the file format similar as possible to v1 and v2: the magic header, compression, and json format remain the same; the version is bumped to 3; and the json document must contain a key "flavor" that specifies static/dynamic.
The upside is that the code/format remains more similar to before (though, I'm not sure anyone actually uses this format or cares about its compatibility). A downside is that there's an additional json decoding pass used to extract version/flavor, but I dont think this should be too expensive.
Added tests that demonstrate the new format works as expected (and fixed a couple bugs).
ref #1697
Checklist