Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf: add dynamic support #1765

Merged
merged 25 commits into from
Oct 19, 2023
Merged

protobuf: add dynamic support #1765

merged 25 commits into from
Oct 19, 2023

Conversation

williballenthin
Copy link
Collaborator

@williballenthin williballenthin commented Aug 25, 2023 •
edited
Loading

Update the proto output format to account for dynamic analysis results. This required deprecating two fields and adding two new ones:

  • RuleMetadata.scope → RuleMetadata.scopes
  • Metadata.analysis → Metadata.analysis2

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

@williballenthin williballenthin added enhancement New feature or request breaking-change introduces a breaking change that should be released in a major version gsoc Work related to Google Summer of Code project. dynamic related to dynamic analysis flavor labels Aug 25, 2023
@yelhamer yelhamer mentioned this pull request Aug 25, 2023
Merged
18 tasks
@williballenthin williballenthin added this to the v7.0 milestone Oct 16, 2023
@williballenthin williballenthin marked this pull request as draft October 19, 2023 09:22
williballenthin
williballenthin commented Oct 19, 2023
View reviewed changes
.github/workflows/tests.yml Outdated
Comment on lines 98 to 101
- name: Run tests (fast)
# this set of tests runs about 80% of the cases in 20% of the time,
# and should catch most errors quickly.
run: pre-commit run pytest-fast --all-files
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated, but useful, enhancement

@williballenthin williballenthin marked this pull request as ready for review October 19, 2023 10:36
mr-tz
mr-tz approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and I trust the round trip and other tests

@williballenthin
pre-commit: fix stages
b6a0d6e
@williballenthin
doc
84e22b1
@williballenthin
ci: only run BN and Ghidra tests after others complete
c724a4b 
these are much less likely to fail because they're
changed less often, so don't run them until we know
other tests also pass.
@williballenthin williballenthin merged commit d42829d into dynamic-feature-extraction Oct 19, 2023
5 checks passed
@williballenthin williballenthin deleted the fix/dynamic-proto branch October 19, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-tz mr-tz mr-tz approved these changes

@yelhamer yelhamer Awaiting requested review from yelhamer

Assignees
No one assigned
Labels
breaking-change introduces a breaking change that should be released in a major version dynamic related to dynamic analysis flavor enhancement New feature or request gsoc Work related to Google Summer of Code project.
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@williballenthin @mr-tz