Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken link in silent-refresh documentation pointing to token-refresh #1130

Conversation

michaelbe812
Copy link
Contributor

This PR targets issue #1129.

I hope this PR is fine (was not totally sure about the contribution guidelines).

It's my first PR to OS so please be patient with me 😛

@@ -1,6 +1,6 @@
## Refreshing when using Implicit Flow (Implicit Flow and Code Flow)

**Notes for Code Flow**: You can also use this strategy for refreshing tokens when using code flow. However, please note, the strategy described within [Token Refresh](./token-refresh.md) is far easier in this case.
**Notes for Code Flow**: You can also use this strategy for refreshing tokens when using code flow. However, please note, the strategy described within [Token Refresh](./token-refresh.html) is far easier in this case.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about changing the extension here, it should be automatically transformed by the MD to HTML parser

Copy link
Contributor Author

@michaelbe812 michaelbe812 Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also what I thought initially. Thought that it is enough to include it in summary.json so that the page is generated and then when generating the html files, the .md references will be replaced by the respective .html-pages.

However this didn't work out, so I had a look at other places where pages are referenced. For instance in docs-src/popup.md you will find this line: - Create and configure a ``silent-refresh.html`` as described [here](./silent-refresh.html) *.

There are also other places where it's handled like this (e.g. in docs-src/session-checks.md).

I guess the parser is not able to replace it (will read about it

@manfredsteyer manfredsteyer merged commit 66daa99 into manfredsteyer:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants