Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken link in silent-refresh documentation pointing to token-refresh #1130

Merged
merged 1 commit into from
Nov 12, 2021
Merged

docs: fix broken link in silent-refresh documentation pointing to token-refresh #1130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs-src/silent-refresh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Refreshing when using Implicit Flow (Implicit Flow and Code Flow)

**Notes for Code Flow**: You can also use this strategy for refreshing tokens when using code flow. However, please note, the strategy described within [Token Refresh](./token-refresh.md) is far easier in this case.
**Notes for Code Flow**: You can also use this strategy for refreshing tokens when using code flow. However, please note, the strategy described within [Token Refresh](./token-refresh.html) is far easier in this case.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about changing the extension here, it should be automatically transformed by the MD to HTML parser

Copy link
Contributor Author

@michaelbe812 michaelbe812 Oct 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also what I thought initially. Thought that it is enough to include it in summary.json so that the page is generated and then when generating the html files, the .md references will be replaced by the respective .html-pages.

However this didn't work out, so I had a look at other places where pages are referenced. For instance in docs-src/popup.md you will find this line: - Create and configure a ``silent-refresh.html`` as described [here](./silent-refresh.html) *.

There are also other places where it's handled like this (e.g. in docs-src/session-checks.md).

I guess the parser is not able to replace it (will read about it


To refresh your tokens when using implicit flow you can use a silent refresh. This is a well-known solution that compensates the fact that implicit flow does not allow for issuing a refresh token. It uses a hidden iframe to get another token from the auth server. When the user is there still logged in (by using a cookie) it will respond without user interaction and provide new tokens.

Expand Down
5 changes: 4 additions & 1 deletion docs-src/summary.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@
"title": "Silent Refresh",
"file": "silent-refresh.md"
},

{
"title": "Token Refresh",
"file": "token-refresh.md"
},
{
"title": "Working with HttpInterceptors",
"file": "interceptors.md"
Expand Down