Improve behaviour of background workers #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ric analysis jobs so that we don't spam the CPU with 5 at a time
Floppy
added
improvement
Floppy
force-pushed
the
rearrange-workers
branch
from
9123de6
to
46229f3
Compare
Floppy
force-pushed
the
rearrange-workers
branch
from
b7db937
to
ced4cf3
Compare
|
Code Climate has analyzed commit ced4cf3 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 86.2% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the behaviour of the job runners. It adds a separate "performance" runner which can be scaled independently, and which takes care of the CPU/MEM intensive jobs like GeometricAnalysis and FileConversion.
Default scaling is that there is only one performance runner - this avoids the entire server becoming CPU-saturated when those jobs are queued up.
Concurrency can be controlled with
DEFAULT_WORKER_CONCURRENCY(default 4) andPERFORMANCE_WORKER_CONCURRENCY(default 1)It also reinstates sidekiq's retry functionality to handle things like database pool exhaustion.