This repository has been archived by the owner on Oct 30, 2021. It is now read-only.
phrasematch performance improvements #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -984,31 +993,36 @@ void _phrasematchPhraseRelev(uv_work_t* req) { | |||
|
|
|||
| // get relev back to float-land. | |||
| relev = relev / total; | |||
There was a problem hiding this comment.
Best practice here would be:
relev = relev / static_cast<double>(total);
Just do make explicit that you are going to doubles. If relev were not already a double you might suffer from integer division bugs: mapbox/mapbox-gl-native#1406
|
This approach is too strict, in particular the very early exit for when relev = 5. Closing this out for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some nice speedups.
Roughly the goal is to return a list of max-scored phrases from a set. Previously this amounted to two loops:
The optimization is to contribute to up to 6 potential lists of phrases as the first loop occurs -- one for each potential highest score value (if the highest score is 5 add to phrases5 list, 4 phrases 4 list, etc.) with early exits as we know sooner that various scores are not going to be the highest (e.g. as soon as we encounter a score 4 we know we don't need to consider phrases with score < 4).