This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
[search] add "collapse" option #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
May 15, 2019 14:12
* master: 0.12.2 [search] debounce search results (#129)
|
@colleenmcginnis No rush on this review since we likely won't roll side-wide search out until after next week |
|
@katydecorah the code looks great! The search bar popping over the tab text was not sitting right with me so I started playing around with another approach (which def would need to be refined) in #133. Let me know what you think! |
|
closes in favor of #133 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
collapse={true}then the search component will collapse into a button:When the button is clicked/focused, the input will expand. The input will overlap anything to its left so that it will fit in the space without breaking the layout:
Once the user clicks way from the opened input, it will collapse again.
On smaller screens/mobile, the collapse option disables to reveal the full input:
QA
Responsive
Cross-browser
Review
⏲ No rush