-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
* master: 0.12.2 [search] debounce search results (#129)
…search icon bigger in input; add hover styles to button
… for narrow instances
@colleenmcginnis this is amazing!!!!! I hopped in with some design and accessibility tweaks. I also added two props Default componentAdded a "Search" label for additional context and light styling Dark vs light
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colleenmcginnis want to give this a second look?
✅ The updates look beautiful, @katydecorah! I did notice the button extending outside the lines just before hitting the breakpoint in this example, but I guess this would be solved by using the |
@colleenmcginnis thanks for flagging! I think we should be ok. Looking at /mapbox-gl-js The navigation folds to two lines and the Search component should follow suit. The test case isn't as robust as the actual application, but I'll look out for this during the install process. |
Gonna QA before the merge: Responsive
Cross-browser
|
* master: prepare 0.13.0 adjust version-sort for XX.XX.XX format (#132)
* master: [search] Introduce search modal (#133)
* master: add snapshot tests (#136) 0.15.1 Prepare 0.15.1 0.15.0 Prepare 0.15.0 [search] adds segment tracking for queries and clicks (#140) [search] add ability to filter results (#138) increase modal zindex to prevent collision with topbar sticker (#139) 0.14.0 Prepare 0.14.0 [PageLayout/TopbarSticker] increase zIndex (#134) [search] Introduce search modal (#133) prepare 0.13.0 adjust version-sort for XX.XX.XX format (#132)
@katydecorah I had (maybe too much) fun exploring some possibilities here. This approach builds on your PR (#130) using a modified/simplified version of the mr-ui
Modal
component with a search bar in it on wide screens and uses the regular search bar below tabs on narrow screens.Take a look and let me know what you think! If you think this is too complex for this stage of testing we can revisit this idea later. I think pulling this out of the top bar could also give us more room to add filters or other options in the future.
Wide screens:

Narrow screens:
