Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

[search] Introduce search modal #133

Merged
merged 31 commits into from
May 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
4f30442
add collapse option
May 15, 2019
1177f17
Merge branch 'master' into search-collapse
May 15, 2019
63cc3b7
Update search-test-cases.js
May 15, 2019
6d7934b
hiding initial input value via transparent text, hacky hacky
May 15, 2019
adfa88a
hide loader if collapsed
May 15, 2019
8e3ff67
Update search-test-cases.js
May 15, 2019
e19428e
only handle collapse if props.collapse
May 15, 2019
08d268d
Update search-test-cases.js
May 15, 2019
09069cd
clean up
May 16, 2019
57a6f9e
clean up
May 16, 2019
f0eacad
create inputId for testing
May 16, 2019
896481a
add tests
May 16, 2019
64219b0
use positioning classes
May 16, 2019
22dcc03
build search modal
colleenmcginnis May 25, 2019
7d946a9
use a button instead of label to trigger modal (accessibility); make …
May 29, 2019
215fd88
larger font size; we have the space!
May 29, 2019
db8514f
adjust close button sizing/positioning
May 29, 2019
5538870
only make icon larger for modal
May 29, 2019
68296be
add "Search" to icon for context; add `narrow` option to remove label…
May 29, 2019
6aecbc4
created `disableModal` option for when you want a search bar (use cas…
May 29, 2019
80e38b0
remove unused attr
May 29, 2019
5f9c027
Update search-test-cases.js
May 29, 2019
8dbcbef
set svg title for `narrow` button for accessibility
May 29, 2019
7378c2f
update tests
May 29, 2019
31bfa36
fix tests
May 30, 2019
001aa6a
Update search.test.js
May 30, 2019
9eeecea
Merge branch 'master' into search-modal-possibly
May 30, 2019
9bcb286
Update CHANGELOG.md
May 30, 2019
3316644
clean up package-lock.json
May 30, 2019
4081bf8
rm unused class
May 30, 2019
cc33703
set placeholder, inputId as defaultProps
May 30, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## Master

- Refactors the `Search` component to use a modal on larger screens. [#133](https://github.com/mapbox/dr-ui/pull/133).

## 0.13.0

- Use [`compare-versions`](https://www.npmjs.com/package/compare-versions) in the version-sort helper function. [#132](https://github.com/mapbox/dr-ui/pull/132)
Expand Down
31 changes: 15 additions & 16 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"cp-assembly": "del ./src/test-cases-app/dist && cpy node_modules/@mapbox/mbx-assembly/dist/*.* ./src/test-cases-app/dist && cpy src/css/docs-prose.css ./src/test-cases-app/dist && cpy src/css/prism.css ./src/test-cases-app/dist",
"budo": "budo test/app.js -l -d -P -- -t babelify",
"prestart": "npm run build-component-index && npm run cp-assembly",
"test": "jest tests/*.test.js",
"test": "jest",
"build-component-index": "rtk-index ./src/components ./src/test-cases-app/component-index.js",
"lint": "eslint .",
"pretest": "npm run lint",
Expand Down Expand Up @@ -59,7 +59,9 @@
"prettier": "^1.16.1",
"prop-types": "^15.6.2",
"react": "^16.7.0",
"react-aria-modal": "^3.0.0",
"react-dom": "^16.7.0",
"react-test-renderer": "^16.8.6",
"unist-util-visit": "^1.4.0"
},
"dependencies": {
Expand All @@ -73,5 +75,8 @@
"react-html-parser": "^2.0.2",
"react-stickynode": "^2.1.1",
"rehype-sectionize-headings": "^1.0.0-rc.1"
},
"jest": {
"testRegex": ".*\\.test\\.js$"
}
}
3 changes: 2 additions & 1 deletion src/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"root": true,
"parser": "babel-eslint",
"env": {
"browser": true
"browser": true,
"jest": true
},
"extends": [
"@mapbox/eslint-config-mapbox/react",
Expand Down
Loading