Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Commit template developer-config.xml #1011

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Apr 4, 2019

The file was already gitignored but no template file was committed.
Closes #1003

@tobrun tobrun added the bug 🐛 label Apr 4, 2019
@tobrun tobrun self-assigned this Apr 4, 2019
@tobrun tobrun requested a review from langsmith April 4, 2019 14:12
Copy link
Contributor

@langsmith langsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥗 thanks

@tobrun tobrun merged commit 48f02a5 into master Apr 5, 2019
@osana
Copy link
Contributor

osana commented Apr 9, 2019

@tobrun after I rebased #1012 to include this PR I started seeing the following from CI

image

@null string was used for the token and Mapbox.getTelemetry() ended up to be null =>
Mapbox.getTelemetry().setDebugLoggingEnabled(true); resulted in NPE

@langsmith suggested to delete the templet file. Once I did this CI was able to complete successfully

@langsmith
Copy link
Contributor

@tobrun , what happens when you make a local change to the developer-config.xml file in the SharedCode module repo? Does git ignore the change on your computer? I believe it should ignore it. I believe the changes introduced in this pr are overriding the access_token value in the SharedCode module's developer-config.xml file, which leads to map tiles not loading because null is used for the token in the MapboxAndroidDemo's developer-config.xml file.

@langsmith langsmith deleted the tvn-fixup-ignored-file branch April 11, 2019 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants