Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Tile loading performance measurement #1012

Merged
merged 1 commit into from
May 16, 2019
Merged

Tile loading performance measurement #1012

merged 1 commit into from
May 16, 2019

Conversation

osana
Copy link
Contributor

@osana osana commented Apr 5, 2019

This PR is based on OkHttp Network Interceptor and the available support in Android Maps SDK for Performance measurement TelementryDefinition, PerformanceEvent

The following measurements are collected:
attributes:

  • requestUrl (without token)
  • responseCode
  • connectionState (none, cellular, wifi)

counters:

  • elapsedMS (number in ms)

device metadata:

  • os : android
  • manufacturer
  • brand
  • version : (as reported by Build.VERSION.RELEASE)
  • abi
  • country : (ISO3 country format)
  • ram
  • screenSize : {width, height}

@osana osana force-pushed the osana-perf-event branch 2 times, most recently from a9b00be to c58a362 Compare April 5, 2019 22:13
@osana osana requested review from tobrun, langsmith and zugaldia April 5, 2019 22:25
@osana osana force-pushed the osana-perf-event branch 2 times, most recently from a322934 to 0be21ba Compare April 5, 2019 22:28
@osana osana force-pushed the osana-perf-event branch 2 times, most recently from d39fbda to acaa714 Compare April 9, 2019 02:12
@osana
Copy link
Contributor Author

osana commented Apr 9, 2019

Output showing that events are posted to staging (using metadata from Android maps sdk Test app)

image

@osana
Copy link
Contributor Author

osana commented Apr 10, 2019

Next on my list to verify that posting to production works. Unfortunately, at the moment I am not seeing TelemetryClient output (in case of production endpoint ) due to mapbox/mapbox-gl-native#14376, which is actually because of
mapbox/mapbox-events-android#382

I will try to run against custom .aar of gl-native that will show the response code from the TelemetryClient

@osana
Copy link
Contributor Author

osana commented Apr 18, 2019

I tried running against custom .aar with little success so I thought it is not worth spending more time on this. Staging is confirmed to work all the way to Mode.
Production is hard to track due to no logging from telemetry due to a bug mapbox/mapbox-events-android#382
Having the logging output would simplify catching the event in Mode (for example using sessionId).

Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but we need to update to 7.4.0 final before merging

@zugaldia
Copy link
Member

@osana what are the next steps to get this PR merged?

@tobrun
Copy link
Member

tobrun commented May 10, 2019

@osana what are the next steps to get this PR merged?

releasing 7.4.0 and updating the maps dependency to it.

@osana osana force-pushed the osana-perf-event branch from bf12b5e to 4eff6a3 Compare May 10, 2019 18:27
@osana
Copy link
Contributor Author

osana commented May 10, 2019

Added connectivity state to attributes.
"wifiOn" will be set to true or false depending on connectivity

Running against pinned Maps sdk 7.4.0-20190508.212927-142 (that has telemetry listener set )
image

@osana osana force-pushed the osana-perf-event branch from 4eff6a3 to 720ef7e Compare May 15, 2019 01:23
@osana osana closed this May 15, 2019
@osana osana reopened this May 15, 2019
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.4.0 got released 🎉

@osana osana merged commit 66f3d08 into master May 16, 2019
@osana osana deleted the osana-perf-event branch May 16, 2019 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants