-
Notifications
You must be signed in to change notification settings - Fork 493
Conversation
797c025
to
af86cdc
Compare
4e48734
to
d67f773
Compare
069a6b2
to
d775ab7
Compare
d775ab7
to
e092ec1
Compare
4ed5316
to
3ae2601
Compare
ffad6cf
to
b608507
Compare
28208ea
to
112ab5e
Compare
Phew, finally ready for review when ya'll get a chance. It's no longer in the actual pr, but during testing, I set up forcing a test crash as documented at https://firebase.google.com/docs/crashlytics/force-a-crash. After linking the debug version from Fabric to Firebase, the crashes started to come into the Firebase console. Couple of things to know about this pr:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Main request for change is to optimize circle configuration for external pull request. We don't allow using env variables for them and we shouldn't execute steps that rely on them. See https://github.com/mapbox/mapbox-gl-native/blob/master/circle.yml#L573 for an example.
MapboxAndroidDemo/src/global/java/com/mapbox/mapboxandroiddemo/MapboxApplication.java
Show resolved
Hide resolved
Ok @tobrun , I've addressed your feedback
I believe 6e313e0 correctly addresses the key/secret generation in the way you were envisioning. If not, let me know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
231b55d
to
152fea4
Compare
Resolves #625