Refine Obj-C bridging for CoordinateBounds #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
reviewed
Dec 8, 2018
| @@ -22,7 +22,7 @@ public class CoordinateBounds: NSObject, Codable { | |||
| /** | |||
| Initializes a `BoundingBox` from an array of `CLLocationCoordinate2D`’s. | |||
| */ | |||
| @objc | |||
| @objc(initWithCoordinates:) | |||
| convenience public init(_ coordinates: [CLLocationCoordinate2D]) { | |||
There was a problem hiding this comment.
The Objective-C signature would be correct but for this _. _ should only be used in exceptional cases.
There was a problem hiding this comment.
This is now a breaking change so we have to bump the minor version number for next release.
frederoni
force-pushed
the
fred/objc-refine-coordb
branch
from
f08ed9b
to
2e25275
Compare
1ec5
added
the
backwards incompatible
|
Added this breaking change to the changelog in 8824016. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change so we have to bump the minor version number for next release.
cc @1ec5 @JThramer