Expose offline routing functionality to Obj-C #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederoni
commented
Dec 6, 2018
| coordinates = @[[NSValue valueWithMKCoordinate:CLLocationCoordinate2DMake(0, 0)], | ||
| [NSValue valueWithMKCoordinate:CLLocationCoordinate2DMake(1, 1)]]; | ||
|
|
||
| MBCoordinateBounds *bounds = [[MBCoordinateBounds alloc] init:coordinates]; |
There was a problem hiding this comment.
init should be refined for Obj-C
1ec5
reviewed
Dec 8, 2018
| @@ -89,7 +89,7 @@ public class NavigationDirections: Directions { | |||
| - parameter progressHandler: Unpacking reports progress every 500ms. | |||
| - parameter completionHandler: Called when unpacking completed. | |||
| */ | |||
| public class func unpackTilePack(at filePathURL: URL, outputDirectoryURL: URL, progressHandler: UnpackProgressHandler?, completionHandler: UnpackCompletionHandler?) { | |||
| @objc public class func unpackTilePack(at filePathURL: URL, outputDirectoryURL: URL, progressHandler: UnpackProgressHandler?, completionHandler: UnpackCompletionHandler?) { | |||
There was a problem hiding this comment.
Suggested change
| @objc public class func unpackTilePack(at filePathURL: URL, outputDirectoryURL: URL, progressHandler: UnpackProgressHandler?, completionHandler: UnpackCompletionHandler?) { | |
| @objc(unpackTilePackAtURL:outputDirectoryURL:progressHandler:completionHandler:) | |
| public class func unpackTilePack(at filePathURL: URL, outputDirectoryURL: URL, progressHandler: UnpackProgressHandler?, completionHandler: UnpackCompletionHandler?) { |
1ec5
approved these changes
Dec 13, 2018
There was a problem hiding this comment.
Suggestion for the changelog:
- The
NavigationDirections.unpackTilePack(at:outputDirectoryURL:progressHandler:completionHandler:)method is now available to Objective-C code as-[MBNavigationDirections unpackTilePackAtURL:outputDirectoryURL:progressHandler:completionHandler:]. (#1891)
akitchen
reviewed
Dec 14, 2018
| @@ -41,6 +42,43 @@ - (void)testUpdateRoute { | |||
| _routeController.routeProgress = [[MBRouteProgress alloc] initWithRoute:route legIndex:0 spokenInstructionIndex:0]; | |||
| [self waitForExpectations:@[expectation] timeout:5]; | |||
| } | |||
|
|
|||
| // This test is excluded from the test suite. We are just verifying that offline routing bridges to Obj-C at compile time. | |||
There was a problem hiding this comment.
Are we excluding it because the networking is currently unstubbed?
There was a problem hiding this comment.
Yes, kind of. These tests are just to make sure we don't regress Obj-C bridging.
We have offline tests for fetching available versions, downloading tiles, and unpacking tiles written in Swift with stubbed network.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tail work from #1808 , offline routing now bridges to Obj-C.
cc @1ec5 @JThramer