Oreo Background Service Crash #157

electrostat · 2018-05-30T20:35:21Z

With developers targeting Api 26+ now, background service no longer works and is creating a crash. Reworking system to prevent this crash and be Oreo optimized.

- update support library version - add architecture lifecycle dependencies

- create and integrate ApplicationLifecycleObserver - start and kill service when moving between background and foreground

LukasPaczos · 2018-06-07T13:35:05Z

libtelemetry/src/main/java/com/mapbox/android/telemetry/MapboxTelemetry.java

@@ -488,7 +490,12 @@ private PermissionCheckRunnable obtainPermissionCheckRunnable() {
  }

  private void startLocation() {
-    applicationContext.startService(obtainLocationServiceIntent());
+    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
+      applicationContext.startForegroundService(obtainLocationServiceIntent());


You could additionally ensure that the service is not started from the background by wrapping this line with ProcessLifecycleOwner.get().lifecycle.currentState.isAtLeast(Lifecycle.State.STARTED).

Nice catch.

starting a long- lived foreground service should only be done when absolutely necessary. It will trigger the OS (Android 8) to show a notification "Application X" is consuming your battery.

@florianPOLARSTEPS that is correct, but I am killing the service when the app enters the background to avoid this issue. When returning to the foreground, the service is spun up again and continues collecting and processing event data.

@electrostat Alright, thanks... I just noticed the LifecyleObserver, sorry about that.

- check to see if device is in background before starting service and lifecycle monitoring

tobrun · 2018-06-08T06:23:49Z

libtelemetry/src/main/java/com/mapbox/android/telemetry/TelemetryService.java

+
+  private void initiateForegroundService() {
+    Notification notification = new Notification();
+    startForeground(1375, notification);


Will this result in showing a notification to the end user?

If your service is started (running through Context.startService(Intent)), then also make this service run in the foreground, supplying the ongoing notification to be shown to the user while in this state.

also:

Apps targeting API Build.VERSION_CODES.P or later must request the permission Manifest.permission.FOREGROUND_SERVICE in order to use this API.

Per the above comment, I actually disable the foreground service when the application enters the background, thus removing the notification.

The Android P permission is a new one to me. Haven't looked at the documentation for that yet, but will give it a look. I'm planning on being P compliant much earlier than we are getting to Oreo.

LukasPaczos · 2018-06-08T06:35:23Z

What's the advantage of using a foreground service in this context? Couldn't we use a background, sticky service? How sensitive is the event processing that it can't be interrupted?

electrostat · 2018-06-08T15:00:37Z

@LukasPaczos Thanks for bringing up this line of thought. I did some digging and realized I made a mistake in my interpretation of the documentation. I read it as removing the startService functionality all together, not just in the background. So they were forcing everyone over to using a foreground service. That's incorrect. We can't start a service while in the background through this method and need to use startForeground service instead. Given this new insight, your earlier suggestion is likely all we need to fix this issue.

Our system is robust and can be interrupted freely, so no worries there. My original solution would've faced the same issues.

I will make the change and test accordingly.

- move maven repo - remove lifecycle observer - check if app is in foreground before starting service - remove all code related to lifecycle observer

- made foreground check only valid for oreo and up environments - additionally fixes failing test

LukasPaczos · 2018-06-12T15:40:54Z

I haven't tested it, but based on the Maps SDK setup if a user calls Mapbox#getInstance (effectively initializing telemetry) from the Application#onCreate, or #onCreate of the first Activity (based on ProcessLifecycleOwner docs) the app's process won't be in a Lifecycle.State.STARTED state yet. This means, that we need to keep lifecycle components around to start the service when we eventually do reach that state on Oreo devices, is that right or am I missing something here?

LukasPaczos · 2018-06-12T15:51:34Z

gradle/dependencies.gradle

+            okhttp3             : '3.10.0',
+            gson                : '2.8.2',
+            espressoVersion     : '3.0.1',
+            archLifecycleVersion: "1.0.0"


Would there be any benefits to bumping arch components version? I think 1.1.1 requires support lib 27+, but maybe we could use 1.1.0?

Nope 1.1.1 is good with supportLib of 26.1.0

- bump lifecycle dependency to 1.1.1 - make MapboxTelemetry a LIfecycleObserver - if oreo and not yet "STARTED" will listen for app to be in the foreground then create service (and kill listener)

LukasPaczos

One minor request, otherwise looks great 🚀

LukasPaczos · 2018-06-15T11:24:28Z

gradle/dependencies.gradle

@@ -33,6 +34,10 @@ ext {
            // play services
            gmsLocation            : "com.google.android.gms:play-services-location:${version.gmsLocation}",

+            //architecture components
+            archLifecycleExtensions: "android.arch.lifecycle:extensions:${version.archLifecycleVersion}",


We can save some weight here by using android.arch.lifecycle:runtime:${version.archLifecycleVersion} dependency instead of extensions as we are not using ViewModel or LiveData.

Capturing from a chat that it seems like runtime does not contain ProcessLifecycleOwner so we need to stick to extensions.

@electrostat any good reason why @LukasPaczos suggestion to cut on weight was not addressed and PR still got merged?

@andrlee Yes, per the above comment we discussed that ProcessLifecycleOwner' is not included in runtime, so we had to keep extensions`. We tested and discussed over slack the issue and was just captures in the brief above comment.

we could still exclude livedata and viewmodel right? We shouldn't be including unnecessary deps.

… foreground Closes #21 re mapbox/mapbox-events-android#157

Add and update dependencies

439dc3d

- update support library version - add architecture lifecycle dependencies

electrostat added bug in progress labels May 30, 2018

electrostat self-assigned this May 30, 2018

ApplicationLifecycleObserver

35d006b

- create and integrate ApplicationLifecycleObserver - start and kill service when moving between background and foreground

This was referenced May 30, 2018

MapBox 6.1.3 Android Telemetry Crash Persist mapbox/mapbox-gl-native#11994

Closed

Not allowed to start service Intent, Android Oreo. mapbox/mapbox-gl-native#12033

Closed

electrostat requested review from tobrun and LukasPaczos June 6, 2018 17:41

LukasPaczos reviewed Jun 7, 2018

View reviewed changes

Check background status before starting

acd1f05

- check to see if device is in background before starting service and lifecycle monitoring

tobrun reviewed Jun 8, 2018

View reviewed changes

electrostat added 3 commits June 8, 2018 13:30

Remove lifecycle observer

4433cc3

- move maven repo - remove lifecycle observer - check if app is in foreground before starting service - remove all code related to lifecycle observer

Foreground check for Oreo+

14299d8

- made foreground check only valid for oreo and up environments - additionally fixes failing test

Merge branch 'master' into aa-oreo-service-crash-fix

fd6b77d

electrostat mentioned this pull request Jun 8, 2018

IllegalStateException: Not allowed to start service Intent (Android O) #129

Closed

LukasPaczos reviewed Jun 12, 2018

View reviewed changes

zugaldia mentioned this pull request Jun 14, 2018

Release Android v6.1.3 mapbox/mapbox-gl-native#11990

Closed

23 tasks

LifeCycleObserver

afb487f

- bump lifecycle dependency to 1.1.1 - make MapboxTelemetry a LIfecycleObserver - if oreo and not yet "STARTED" will listen for app to be in the foreground then create service (and kill listener)

electrostat added ready for review and removed in progress labels Jun 14, 2018

LukasPaczos suggested changes Jun 15, 2018

View reviewed changes

LukasPaczos approved these changes Jun 15, 2018

View reviewed changes

electrostat merged commit 1f65ec6 into master Jun 15, 2018

electrostat deleted the aa-oreo-service-crash-fix branch June 15, 2018 15:18

electrostat mentioned this pull request Jul 6, 2018

Investigate and Fix possible Doze bug #174

Closed

LukasPaczos mentioned this pull request Jul 18, 2018

Conflict android.arch.lifecycle:runtime:1.1.0 -> 1.1.1 When using version 6.2.1 and Android Support libs mapbox/mapbox-gl-native#12383

Closed

lilykaiser mentioned this pull request Aug 28, 2018

App crashes on Android 8.0 using Mapbox SDK 6.3.0 mapbox/mapbox-gl-native#12730

Closed

andrlee mentioned this pull request Nov 3, 2018

Remove dependency on lifecycle extensions #273

Closed

jroal mentioned this pull request Nov 20, 2018

App crashes on starting service jroal/a2dpvolume#271

Closed

mandrigin mentioned this pull request Jan 24, 2019

Get rid of StatusService. status-im/status-mobile#7334

Merged

bk138 added a commit to bk138/multivnc that referenced this pull request Sep 6, 2019

Android: use LifeCycleObserver to make sure MDNSService is started in…

a9df24b

… foreground Closes #21 re mapbox/mapbox-events-android#157

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Oreo Background Service Crash #157

Oreo Background Service Crash #157

electrostat commented May 30, 2018

LukasPaczos Jun 7, 2018

electrostat Jun 7, 2018

florianPOLARSTEPS Jun 7, 2018

electrostat Jun 7, 2018

florianPOLARSTEPS Jun 8, 2018

tobrun Jun 8, 2018

electrostat Jun 8, 2018

LukasPaczos commented Jun 8, 2018

electrostat commented Jun 8, 2018

LukasPaczos commented Jun 12, 2018

LukasPaczos Jun 12, 2018

electrostat Jun 14, 2018

LukasPaczos left a comment

LukasPaczos Jun 15, 2018

LukasPaczos Jun 15, 2018

andrlee Nov 3, 2018

electrostat Nov 5, 2018

andrlee Nov 5, 2018

Oreo Background Service Crash #157

Oreo Background Service Crash #157

Conversation

electrostat commented May 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LukasPaczos commented Jun 8, 2018

electrostat commented Jun 8, 2018

LukasPaczos commented Jun 12, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LukasPaczos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment