Make locationManager initialization thread safe #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S2Ler
force-pushed
the
hotfix/data-race
branch
2 times, most recently
from
897dd5e
to
c4820c5
Compare
S2Ler
force-pushed
the
hotfix/data-race
branch
from
0125fa1
to
c353240
Compare
MMEMetricsManager is accessed from multiple thread from `sendTurnstileEvent` method.
S2Ler
force-pushed
the
hotfix/data-race
branch
from
c353240
to
bfef1c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #316
There are three data-races found during running
sendTurnstileEventmultiple times:MMELocationManagerMMEMetricsManagerMMEUniqueIdentifierAll these classes modify shared state which is accessed from multiple Dispatch Queue threads due to how
sendTurnstileEventis implemented.Alternative solution can be running
sendTurnstileEventonly one at a time.