Safari broken after recent shader changes

[mourner]

#1257 broke Safari on both desktop and iOS. It starts to look bad at ba36586 and goes completely broken on 88f138a.

We'll probably have to either find a fix quickly, or revert the changes until we find a solution.

cc @lucaswoj @ansis

[lucaswoj]

Huh. Weird. I was testing on Safari and everything seemed ok. I'm OOO for the night so please revert if you're blocked. Will take a look first thing tomorrow.

On Thu, Jun 11, 2015 at 7:07 PM, Vladimir Agafonkin
notifications@github.com wrote:

#1257 broke Safari on both desktop and iOS. It starts to look bad at ba36586 and goes completely broken on 88f138a.

We'll probably have to either find a fix quickly, or revert the changes until we find a solution.

cc @lucaswoj @ansis

Reply to this email directly or view it on GitHub:
#1268

[mourner]

@lucaswoj no worries, let's look tomorrow.

[lucaswoj]

Just double checked and I'm seeing beautiful Mapbox Streets in Safari on f5a34c61ef2e5423b77ca7ef5e4dc52a28ff7d39

I'll play around with other browsers and other platforms tonight.

Are you seeing any console output @mourner?

[lucaswoj]

That being said, I have acknowledged that some intermediate commits in this PR were silently broken (i.e. not causing test failures but had faults). I would expect trouble running anything in this PR before 1c34f178776a0dc1c78a2e613c4a8f0ae6896124

[mourner]

@lucaswoj hmm, what's your Safari & OS X version? Also, could you try it on iPhone/iPad?

[lucaswoj]

Same question to you!

[mourner]

The same! Just realized the difference — my discrete videocard is dying so I test GL on integrated card.

[lucaswoj]

This is going to be so much fun! ☕ ☕ ☕

[lucaswoj]

Lets talk tomorrow morning @mourner

[mourner]

WTF, rm -rf node_modules + npm install fixed this.