-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Mobile touch events #949
Conversation
Looking forward to this functionality. Thanks for doing this! |
I gave this a try on my single page app, it works really well apart from one problem I seemed to be having. |
Might be worth ensuring that how the map responds to touch gestures matches what’s been implemented in Mapbox GL for iOS and Android (mapbox/mapbox-gl-native#1292, mapbox/mapbox-gl-native#553). |
What's the status of touch for the web version? |
var zoom = map.transform.scaleZoom(startScale * e.scale), | ||
bearing = startBearing + e.bearing; | ||
|
||
map.easeTo(null, zoom, bearing, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use undefined
here instead of having add the null check on the other side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1215 removes the need for null
or undefined
positional arguments.
Hey guys, Thanks for this! I am able to use mapbox-gl-js on my android phone now because of your great work! I merged the latest master branch into the touch branch, and only had to change a couple of things afterwards to make it work again (at least on my Samsung Galaxy Mini S4) I have published it here: https://github.com/trappsnl/mapbox-gl-js/tree/touch Not sure if I should make a new pull request now? or I guess @edenh can merge my changes into this one? Anyways, I'll try to help as much as I can for Android support, and have some more devices where I will test this on. |
+1 for this. I'm using |
I'll look into finishing and merging this early next week. |
6b7d4ab
to
057d4ab
Compare
Currently broken because of #1268 |
Will handle subsequent improvements in further commits. |
👍 Awesome!! Thanks a lot! |
Previously #749.
A work in progress, resolves #657. Rendering is pretty funny though #750.