Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rotate horizontal labels #159

Closed
kkaefer opened this issue Oct 25, 2013 · 3 comments
Closed

Don't rotate horizontal labels #159

kkaefer opened this issue Oct 25, 2013 · 3 comments
Assignees

Comments

@kkaefer
Copy link
Member

kkaefer commented Oct 25, 2013

Right now we rotate horizontal labels when the user rotates the map. This is because we'd need to compute a collision map as suggested in http://arxiv.org/pdf/1104.5634v1.pdf and integrate that with the current label show/hide code.

@ghost ghost assigned ansis Oct 29, 2013
@ansis
Copy link
Contributor

ansis commented Nov 6, 2013

I just merged support for this into gl. It still needs some cleaning, more tests and performance improvements, but it works! Overall, I'm happy with the quality. It could be improved by adding a second range for a higher zoom level, but even without it its pretty good.

@kkaefer
Copy link
Member Author

kkaefer commented Nov 7, 2013

Yay! This looks very good! Nice work!

@ansis
Copy link
Contributor

ansis commented Nov 11, 2013

Done. Remaining problems have separate issues

@ansis ansis closed this as completed Nov 11, 2013
lucaswoj pushed a commit that referenced this issue Jan 11, 2017
lucaswoj pushed a commit that referenced this issue Jan 11, 2017
Fixes #178
Fixes #191
Fixes #189
Fixes #168
Fixes #160
Fixes #159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants