Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label underscaling #189

Closed
ansis opened this issue Nov 11, 2013 · 7 comments
Closed

label underscaling #189

ansis opened this issue Nov 11, 2013 · 7 comments

Comments

@ansis
Copy link
Contributor

ansis commented Nov 11, 2013

We need to place labels at least a couple zoom levels lower than the tile zoom to prevent labels from flashing when zooming out.

@kkaefer
Copy link
Member

kkaefer commented Nov 11, 2013

yeah, noticed that too. Problem is that if we do this, we get a massive amount of collisions in the rtree.

@ansis
Copy link
Contributor Author

ansis commented Nov 18, 2013

Adding a second rtree should solve this reasonably well.

This was referenced Dec 2, 2013
@kkaefer
Copy link
Member

kkaefer commented Jan 15, 2014

7c1fb59 adds back stencil clipping for labels because the pan tile often has the same labels in slightly different spots, which looks weird. However, this also makes this bug more visible.

@ansis
Copy link
Contributor Author

ansis commented Jan 15, 2014

same labels in slightly different spots

Do you remember if these were point or line labels?

@kkaefer
Copy link
Member

kkaefer commented Jan 15, 2014

point labels. I'm talking about city labels being duplicated, one from the pan tile and once from the actual tile.

@ansis
Copy link
Contributor Author

ansis commented Jan 15, 2014

#194 has two ideas about fixing that. Thinking about that now, I think B is the only one that would really work

@ansis
Copy link
Contributor Author

ansis commented Feb 11, 2014

Done in eb0bfc8 - performance made acceptable by ea6a4b3

@ansis ansis closed this as completed Feb 11, 2014
lucaswoj pushed a commit that referenced this issue Jan 11, 2017
Fixes #178
Fixes #191
Fixes #189
Fixes #168
Fixes #160
Fixes #159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants