-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expression tests should check "serialized" #6253
Labels
Comments
Yeah -- it wouldn't be too hard to add |
anandthakker
added
the
GL native → GL JS
For feature parity with Mapbox Maps SDK on a native platform
label
Mar 30, 2018
5 tasks
anandthakker
pushed a commit
that referenced
this issue
Apr 6, 2018
Merged
anandthakker
pushed a commit
that referenced
this issue
Apr 6, 2018
Merged
anandthakker
added a commit
that referenced
this issue
Apr 6, 2018
* prettify expression test diff output * Implement Expression#serialize() * Enable GL JS serialization and roundtripping tests Closes #6253 * Show serialized form in test output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
#6181 added functionality to the expression tests to verify that the actual "serialized" representation matches an expected value. However, it omitted a serialization mechanism in the JS implementation; the JS test harness ignores the expected value for existing tests, and bootstraps newly added tests with an "expected" serialization that's copied from the input expression.
This introduces a new source of friction in the gl-js/gl-native workflow: it's easy to create a new expression test in gl-js that fails unexpectedly when pulled into gl-native because the serialized representation is not exactly equivalent to the input expression. When this happens, you have to either ignore that test in gl-native (even if it would otherwise be passing), or pause your current work and update the expected serialization in a gl-js PR.
/cc @ChrisLoer
The text was updated successfully, but these errors were encountered: