Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constant folding #6468

Merged
merged 5 commits into from
Apr 9, 2018
Merged

Fix constant folding #6468

merged 5 commits into from
Apr 9, 2018

Conversation

anandthakker
Copy link
Contributor

@anandthakker anandthakker commented Apr 6, 2018 •
edited
Loading

@anandthakker anandthakker mentioned this pull request Apr 6, 2018
Closed
@anandthakker
Copy link
Contributor Author

I included #6253 in this work because I realized belatedly that it's the most natural way to test the changes.

@anandthakker
Copy link
Contributor Author

anandthakker commented Apr 6, 2018 •
edited
Loading

I included #6253 in this work because I realized belatedly that it's the most natural way to test the changes.

Actually I'll just extract this into a separate PR ( #6469 )

@anandthakker anandthakker force-pushed the fix-constant-folding branch from 5c17dab to ad80a89 Compare April 6, 2018 16:55
@anandthakker anandthakker removed the request for review from ChrisLoer April 6, 2018 16:56
@mollymerp mollymerp assigned mollymerp and unassigned mollymerp Apr 6, 2018
@anandthakker anandthakker force-pushed the fix-constant-folding branch from ad80a89 to c17d3ac Compare April 6, 2018 17:34
@anandthakker
Copy link
Contributor Author

Alright, rebased now that Expression#serlialize() is in master.

jfirebaugh
jfirebaugh approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I have a lingering instinct that isConstant and friends are missing some simplifying abstraction that would make them more straightforward and less dependent on checking a bunch of highly specific conditionals.

@anandthakker
Copy link
Contributor Author

I have a lingering instinct that isConstant and friends are missing some simplifying abstraction that would make them more straightforward and less dependent on checking a bunch of highly specific conditionals

Yeah, I've had the same feeling, but haven't had an idea for the right abstraction click into place yet

mollymerp
mollymerp approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@mollymerp mollymerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me!

@anandthakker anandthakker merged commit b018592 into master Apr 9, 2018
@anandthakker anandthakker deleted the fix-constant-folding branch April 9, 2018 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mollymerp mollymerp mollymerp approved these changes

@jfirebaugh jfirebaugh jfirebaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anandthakker @jfirebaugh @mollymerp