Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable fill extrusion ambient occlusion in v2.10.0 #12134

Closed
wants to merge 1 commit into from
Closed

Disable fill extrusion ambient occlusion in v2.10.0 #12134

wants to merge 1 commit into from

Conversation

stepankuzmin
Copy link
Contributor

No description provided.

@stepankuzmin stepankuzmin added the skip changelog Used for PRs that do not need a changelog entry label Aug 4, 2022
mourner
mourner approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we can just add the render tests to ignores instead of deleting them.

@astojilj
Copy link
Contributor

astojilj commented Aug 8, 2022 •
edited
Loading

Nit: we can just add the render tests to ignores instead of deleting them.

👍
Could we please keep the render tests (ignored) as they are needed for gl-native?

EDIT: didn't see that this is about release branch, not main... please ignore.

@stepankuzmin stepankuzmin mentioned this pull request Aug 9, 2022
Merged
@stepankuzmin
Copy link
Contributor Author

Closing in favor of #12146

@stepankuzmin stepankuzmin deleted the stepankuzmin/disable-ao branch August 11, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
skip changelog Used for PRs that do not need a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stepankuzmin @astojilj @mourner