Make ambient occlusion and edge radius private in the style-spec #12146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepankuzmin
added
the
skip changelog
stepankuzmin
changed the title
This was referenced Aug 9, 2022
mourner
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
👍 also might be worth updating https://github.com/mapbox/mapbox-gl-js/blob/main/build/rollup_plugin_minify_style_spec.js (e.g. add v.type === 'private') to filter those out of the bundle.
|
@mourner unfortunately, removing these properties in the I'm unsure if we want to break the validation for the styles with private properties. So let's not omit them for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes fill extrusion's ambient occlusion and edge radius private in the style-spec package, making #12134 and #12135 obsolete. PR will land into the
main, so we can intentionally make these changes public later. I will cherry-pick it in the release-v2.10.0 branch after the merge.