Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG with 2.10.0 changes #12160

Merged
merged 12 commits into from
Aug 12, 2022
Merged

Update CHANGELOG with 2.10.0 changes #12160

merged 12 commits into from
Aug 12, 2022

Conversation

stepankuzmin
Copy link
Contributor

No description provided.

stepankuzmin and others added 4 commits August 9, 2022 15:37
@stepankuzmin
Make ambient occlusion and edge radius private in the style-spec (#12146
745a210 
)
@mpulkki-mapbox
Fix pole geometry elevation sampling (#12133)
5b9609f 
* Fix elevation sampling for globe pole triangles
@mourner
Fix abrupt jump with globe view + maxBounds after transition to merca…
79af3b6 
…tor (#12124)

* globe: fix abrupt jump with maxBounds after transition to mercator

* add a note to setMaxBounds docs about mercator vs other
@stepankuzmin
Update CHANGELOG with 2.10.0 changes
41d860d
@stepankuzmin stepankuzmin added the skip changelog Used for PRs that do not need a changelog entry label Aug 11, 2022
SnailBones
SnailBones reviewed Aug 11, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
SnailBones
SnailBones reviewed Aug 11, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
SnailBones
SnailBones reviewed Aug 11, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
SnailBones
SnailBones approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@SnailBones SnailBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few nits, otherwise LGTM!

avpeery
avpeery reviewed Aug 11, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
avpeery
avpeery suggested changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@avpeery avpeery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above about some entries being included already in the 2.9.0 release. I'll check for any others!

avpeery
avpeery reviewed Aug 11, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
avpeery
avpeery reviewed Aug 11, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
stepankuzmin and others added 5 commits August 11, 2022 21:43
@stepankuzmin @SnailBones
Update CHANGELOG.md
e64fe10 
Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com>
@stepankuzmin @SnailBones
Update CHANGELOG.md
9bcb96e 
Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com>
@stepankuzmin @SnailBones
Update CHANGELOG.md
761be32 
Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com>
@stepankuzmin @SnailBones
Update CHANGELOG.md
816b49b 
Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com>
@stepankuzmin
Update CHANGELOG.md
a6261ff
@stepankuzmin
Copy link
Contributor Author

Thanks, @SnailBones @avpeery! 🙇

@avpeery
Copy link
Contributor

avpeery commented Aug 11, 2022

Fixed a small typo, looks good to me! thanks @stepankuzmin

SnailBones
SnailBones reviewed Aug 11, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
stepankuzmin and others added 2 commits August 12, 2022 12:16
@stepankuzmin @SnailBones
Update CHANGELOG.md
145ea29 
Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com>
@stepankuzmin
Update CHANGELOG.md
b211fcc
@stepankuzmin stepankuzmin changed the base branch from main to release-v2.10.0 August 12, 2022 12:24
@stepankuzmin stepankuzmin merged commit d0cd268 into release-v2.10.0 Aug 12, 2022
@stepankuzmin stepankuzmin deleted the stepankuzmin/changelog-v2.10.0 branch August 12, 2022 12:29
@SnailBones SnailBones mentioned this pull request Aug 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SnailBones SnailBones SnailBones approved these changes

@avpeery avpeery avpeery approved these changes

Assignees

@SnailBones SnailBones

@avpeery avpeery

Labels
skip changelog Used for PRs that do not need a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stepankuzmin @avpeery @SnailBones @mpulkki-mapbox @mourner