Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another pass at Leaflet-like API #369

Merged
merged 30 commits into from
May 7, 2014
Merged

Another pass at Leaflet-like API #369

merged 30 commits into from
May 7, 2014

Conversation

mourner
Copy link
Member

@mourner mourner commented May 2, 2014

A work in progress. Makes the API more consistent, simple to use and closer to Leaflet conventions.

  • revise all view changing methods, make them more flexible and configurable through options
  • revise Map and Source options, make them more convenient, better defaults
  • add methods that return map state (bounds, center, etc.)
  • pass event data as object with properties rather than array
  • revise all events, make them more consistent and useful
  • fill any remaining important method gaps that Leaflet has and llmr doesn't

This was referenced May 5, 2014
Closed
Closed
mourner added 28 commits May 7, 2014 13:49
@mourner
add LatLngBounds type
388dae6
@mourner
use LatLngBounds in map.fitBounds
306aa08
@mourner
expose map as global for easier debugging
69c7326
@mourner
update easing methods to accept options object everywhere
89ff640
@mourner
change default maxZoom from 18 to 20
003db81
@mourner
fix scroll zoom regression
955a4d7
@mourner
use prototype options in Source
c4e0479
@mourner
Change source urls to url, accept {s} in template
78865c6
@mourner
fix debug page URL templates
716b42d
@mourner
added Source minZoom, maxZoom, skipZooms options
0abcc83
@mourner
fix tile url test
a9c3e08
@mourner
accept string in Map container option
a22d978
@mourner
add easing option to most easing methods
4d2ec0a
@mourner
start updating API docs
203f27e
@mourner
move fitBounds down in the source
adca0ed
@mourner
add offset option to map panTo and zoomTo
4c2e429
@mourner
Add center arg to setAngle, center/offset to rotateTo, close #258
b6be343
@mourner
remove center option, use offset instead for easing methods
8207c7f
@mourner
update API docs
e4b8f66
@mourner
minor API docs correction
4f852dd
@mourner
add Map getBounds, tidy up API docs
c2cd9d5
@mourner
add Map getCenter, getZoom, getAngle
434ee7f
@mourner
add animate: false option to zoomPanTo, fix fitBounds options
a17e436
@mourner
add animate: false option to other easings
e81e0a8
@mourner
cleanup changelog / docs
de62929
@mourner
add rotation anim during zoomPanTo & angle argument
4ed9f65
@mourner
move evented.js from lib to util
98c9123
@mourner
update events to pass data as object rather than array
e2e7965
@mourner
Copy link
Member Author

mourner commented May 7, 2014

Rebased on top of master (with the new style format).

@mourner
Copy link
Member Author

mourner commented May 7, 2014

OK, I think this is good to merge — additional revisions can be done in master.

mourner added a commit that referenced this pull request May 7, 2014
@mourner
Merge pull request #369 from mapbox/api-rev
3204c10 
Another pass at Leaflet-like API
@mourner mourner merged commit 3204c10 into master May 7, 2014
@mourner mourner deleted the api-rev branch May 7, 2014 11:05
bensleveritt pushed a commit to bensleveritt/mapbox-gl-js that referenced this pull request Oct 24, 2016
Add features unit tests; closes mapbox#369
907fe81
lucaswoj pushed a commit that referenced this pull request Jan 11, 2017
@tmcw
Make properties permalinkable.
cf21e3c 
Fixes #369
@1ec5 1ec5 mentioned this pull request Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mourner