Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement compass using DragRotate handler #5157

Merged
merged 1 commit into from
Aug 22, 2017
Merged

Conversation

jfirebaugh
Copy link
Contributor

Reuse the existing code directly, rather than synthesizing mouse events, which doesn't work on IE (#4784) and triggers mouse event listeners unexpectedly (#5148).

Reuse the existing code directly, rather than synthesizing mouse events, which doesn't work on IE (#4784) and triggers mouse event listeners unexpectedly (#5148).
@jfirebaugh jfirebaugh force-pushed the compass-drag-rotate branch from 12f2662 to 4a5233c Compare August 22, 2017 16:38
@jfirebaugh jfirebaugh changed the base branch from drag-events to master August 22, 2017 16:38
Copy link
Contributor

@anandthakker anandthakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

A consequence of this is that if you click and hold on the compass button, then moving the mouse will rotate the map as if you'd clicked directly on the map. I think that's fine, just wanted to note it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants