Fix z-fighting of translucent fills #5206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression test for mapbox-gl-js#2533 was changed slightly to compensate for an incidental difference.
jfirebaugh
force-pushed
the
partial-fix-3320
branch
from
79585ce to
a8e54b9
Compare
kkaefer
approved these changes
Sep 7, 2017
| @@ -26,6 +26,7 @@ function drawFill(painter: Painter, sourceCache: SourceCache, layer: FillStyleLa | |||
| // Once we switch to earcut drawing we can pull most of the WebGL setup | |||
| // outside of this coords loop. | |||
| painter.setDepthSublayer(1); | |||
| painter.depthMask(painter.isOpaquePass); | |||
This was referenced Sep 7, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #3320, as described in #3320 (comment).