Minimize circle render tests #5940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
reviewed
Jan 3, 2018
jfirebaugh
force-pushed
the
optimize-render-tests
branch
from
0875f0c to
011120f
Compare
|
Added a couple tests. I think they exposed an alpha blending bug. Same issue as #3771 maybe.
|
jfirebaugh
force-pushed
the
optimize-render-tests
branch
from
011120f to
46cdfb5
Compare
mourner
approved these changes
Mar 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #5927, the next best thing I've found to make render tests faster is to keep them small (64x64) where possible. This PR does so for the circle tests.