Write PNGs with unassociated alpha #6275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Among the expecteds that I didn't commit, there are a bunch that now are slightly different from (correct) actual, but not enough to trigger pixelmatch. Maybe we should just do an across-the-board update? |
👍 that sounds like a good idea to maintain a reasonable error threshold for those tests. |
jfirebaugh
force-pushed
the
png-unassociated
branch
from
558bed2 to
d80c636
Compare
And update almost all the expected render test results. Skipping: combinations/fill-extrusion-translucent--background-opaque combinations/fill-extrusion-translucent--fill-opaque fill-outline-color/* map-mode/static projection/*
jfirebaugh
force-pushed
the
png-unassociated
branch
from
d80c636 to
aa298d7
Compare
jfirebaugh
force-pushed
the
png-unassociated
branch
from
aa298d7 to
5419993
Compare
mollymerp
pushed a commit
that referenced
this pull request
Mar 6, 2018
mollymerp
added a commit
that referenced
this pull request
Mar 6, 2018
* Add regression test * fix y coordinate of linepattern texture * fix copy pasta * update to reflect #6275 * update tiny diff failing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test harness was sending the GL premultiplied pixel data directly to PNG, which expects unassociated pixel data. This led to test results that looked wrong visually, even though the rendering was correct. See the
expected.pngupdates for examples.(I ran an
UPDATE=1across the board, but only committed theexpected.pngs for tests that were failing after therender.jschange in either JS or native.)Fixes #3771.
Fixes #3913.