-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix drag handlers to gracefully handle interruptions #6113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asheemmamoowala
approved these changes
Feb 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Firefox/Chrome/Safari on macOS.
anandthakker
force-pushed
the
fix-6016
branch
from
February 9, 2018 00:56
95aedfa
to
f3904b2
Compare
anandthakker
added a commit
that referenced
this pull request
Feb 9, 2018
pathmapper
pushed a commit
to pathmapper/mapbox-gl-js
that referenced
this pull request
Feb 13, 2018
Cherry picking mapbox#6113 into master Closes mapbox#6106
pathmapper
pushed a commit
to pathmapper/mapbox-gl-js
that referenced
this pull request
Feb 13, 2018
Cherry picking mapbox#6113 into master Closes mapbox#6106
jfirebaugh
added a commit
that referenced
this pull request
Feb 15, 2018
jfirebaugh
added a commit
that referenced
this pull request
Feb 15, 2018
jfirebaugh
added a commit
that referenced
this pull request
Feb 16, 2018
jfirebaugh
added a commit
that referenced
this pull request
Feb 16, 2018
dave11mj
pushed a commit
to dave11mj/mapbox-gl-js
that referenced
this pull request
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6106