Don't use _onDragFinished as a "finish" callback for _startAnimation #6171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, you’re totally right—this is the right fix. |
anandthakker
approved these changes
Feb 15, 2018
|
@anandthakker Want to 👀 the equivalent changes for |
jfirebaugh
force-pushed
the
alternate-6113-fix
branch
from
f8b7a3f to
1af24ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that this is a better fix for #6106 than #6113. #6113 doesn't address the related issues that an "interruption" by another handler would trigger inertial panning and a
dragendevent, despite the drag remaining in progress until the mouse or touch is released.@anandthakker, if you agree, I will port this approach to
DragRotateHandleras well.