Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advance image request queue when request aborted #7641

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Conversation

ansis
Copy link
Contributor

@ansis ansis commented Nov 29, 2018

fixes #7637

Aborted requests never decremented the number of active requests because the main callback is never called. This fixes that by making getImage return a wrapped version of the getArrayBuffer return value that also advances the queue.

Within advanceImageRequestQueue we need to change that it hasn't already been advanced for that request because sometimes cancel() is called after the request has completed.

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • manually test the debug page

@ansis
Copy link
Contributor Author

ansis commented Nov 30, 2018

@mourner can I get a review of the new commit?

@ansis ansis merged commit 90577a9 into master Nov 30, 2018
@kkaefer kkaefer deleted the fix-image-queue-abort branch December 10, 2018 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

raster tiles fail to load in safari
2 participants