alternative: advance the image request queue when aborting #7642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
requested changes
Nov 30, 2018
There was a problem hiding this comment.
- The build fails because of both test failures and linting errors.
- I'm not sure if we should throw an error on abort since technically it's not an error if it's expected. Maybe for consistency it's worth doing the other way around (suppressing errors on abort in
fetchin advance image request queue when request aborted #7641).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7637
alternative to #7641
The fetch api triggers errors for aborted requests and that seems to not be causing problems so I think it should be safe to do that for xmlhttprequests.
Launch Checklist