This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Implement method to set padding when camera is tracking. #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunDai
force-pushed
the
jd-padding-while-tracking
branch
2 times, most recently
from
e9cb508
to
d0bf8dc
Compare
|
Can you add the API call in test app's |
let me check, thanks. cc: @Chaoba |
JunDai
force-pushed
the
jd-padding-while-tracking
branch
from
d0bf8dc
to
937ff71
Compare
LukasPaczos
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
Amazing work! 🚢 🚢 🚢
With this in place, we should remove the LocationComponentOptions#padding option from next major Maps SDK iterations.
I'm gonna go ahead and resolve those 2 nitpicks below so that we can merge this PR and get it into today's Maps SDK 9.4.0 pre-release.
...tApp/src/main/java/com/mapbox/mapboxsdk/testapp/activity/location/LocationModesActivity.java
Outdated
Show resolved
Hide resolved
...ndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/location/LocationComponentTest.kt
Show resolved
Hide resolved
LukasPaczos
force-pushed
the
jd-padding-while-tracking
branch
from
edaf4b8
to
59f31c1
Compare
LukasPaczos
force-pushed
the
jd-padding-while-tracking
branch
from
59f31c1
to
09cb0bc
Compare
|
@LukasPaczos - thanks a lot for helping merge this PR 🙇 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<changelog>Enabled setting padding while keeping the camera tracking mode.</changelog>This PR implements
paddingWhileTrackingAPI so the developer can set a new padding to the mapview while keeping the camera tracking mode.