This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Crash when converting screencoordinate as part of moveBy #555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we use Transform::moveBy for scrolling and fling gestures. There are cases as reported by customers that sometimes NaN value are produced for the latitude value:
This happens as part of
screenCoordinateToLatLng
within Transform::moveBy.Capturing from @pozdnyakov in an upstream ticket:
This PR addresses above comment by wrapping
nativeMoveBy
and logging the occurrence.