Refactor accessibility calculations #318
Conversation
julianrex
force-pushed
the
jrex/update-accessibility-calcs
branch
from
b90b5df to
4e9878d
Compare
platform/ios/src/MGLMapView.mm
Outdated
| // TODO: | ||
| /*NSArray **/visiblePlaceFeatures = [self visibleFeaturesInRect:bounds inStyleLayersWithIdentifiers:[NSSet setWithArray:placeStyleLayerIdentifiers]]; |
There was a problem hiding this comment.
What’s the to-do item here? (I see that it’s addressed in #319, but I’m not following what the task was.)
There was a problem hiding this comment.
I lifted visiblePlaceFeatures above the if, so that I could use it further below.
jmkiley
force-pushed
the
jrex/update-accessibility-calcs
branch
from
c583c75 to
fb30ebf
Compare
|
@julianrex Made some minor cleanup. I don't see the memory spike with these changes. Will ticket out tail-work around VoiceOver improvements. |
There was a problem hiding this comment.
Synced with @jmkiley and ran this locally. I'm seeing other unrelated flaky test failures with offline, and one accessibility-related failure with MGLTestAccessibilityDictionaryForElement within MGLQueryFeatureTests.
There was a problem hiding this comment.
Per chat with @jmkiley we'll follow up on the test failure locally, since the actual implementation works and I didn't seem to find any noted performance degradation.
jmkiley
force-pushed
the
jrex/update-accessibility-calcs
branch
from
fb30ebf to
08d4f21
Compare
* Port tests from gl-native 14324 * Remove crud. * Set baselines * Add timing for dictionary generation * Remove access token * Use insert access token script to insert an access token * Update accessing the access token * Fix second accessToken * Refactor accessibility calculations (#318) * Port tests from gl-native 14324 * Port accessibility calcs * Fix typo from merge. * Match results from before optimization. * Remove temp commented code * Address some TODOs * Include exception from failing test Co-authored-by: jmkiley <jordan.kiley@mapbox.com> * Update MGLAnnotationViewIntegrationTests.mm Co-authored-by: jmkiley <jordan.kiley@mapbox.com> Co-authored-by: Jordan Kiley <jmkiley@users.noreply.github.com>
This is part 2 of 3 PRs that port mapbox/mapbox-gl-native#15303 to this repo. (See also #317, #319.)
This PR, refactors the accessibility element calculations, caching the results. Previously these were needlessly being called continually. This PR addresses the performance concerns. In addition, I have seen fewer crashes.
Fixes #220.