-
Notifications
You must be signed in to change notification settings - Fork 122
Conversation
cd1f6fd
to
154c8b2
Compare
cc @MaximAlien |
Since we have added an |
Good catch; because it's called "Button" I had assumed it was a
Something other than the compass view needs to have its transform changed. This works for both a subview and a sublayer. I chose a sublayer since it won't play a role in auto-layout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to back-port current fix to version 6.2
as well?
Update transform immediately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good, just one question - does this change any accessibility-related functionality?
@@ -57,7 +57,7 @@ workflows: | |||
- ios-build: | |||
matrix: | |||
parameters: | |||
xcode: ["11.3.1", "11.5.0", "11.6.0", "12.0.0"] | |||
xcode: ["11.1.0", "11.3.1", "12.2.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For next time, I'd maybe consider splitting this into a separate PR.
No, this should be a visual change only. |
Fixes #500
Changing the transform on the compass button triggers
-[UIView layoutSubviews]
on iOS 14. This PR add a sublayer for the compass image, keeping the original UIView's transform intact.The original issue in #500 is not fully resolved however, as the scale bar causes a similar issue (to a lesser extent).