Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Port line tessellation #1

Closed
5 tasks done
kkaefer opened this issue Jan 27, 2014 · 1 comment
Closed
5 tasks done

Port line tessellation #1

kkaefer opened this issue Jan 27, 2014 · 1 comment
Labels
feature
Milestone
0.0.0

Comments

@kkaefer
Copy link
Member

kkaefer commented Jan 27, 2014

  • Create a pendant to FillBuffer that we can use to store the tessellated lines (see JS/LineVertexBuffer)
  • When parsing a tile, tessellate the line. Copy the code from JS from Geometry#addLine
  • Port the line drawing code from painter.js
  • Make it work
  • Respect the line width spec in the stylesheet
@kkaefer kkaefer mentioned this issue Jan 27, 2014
Closed
@kkaefer kkaefer closed this as completed Jan 29, 2014
@kkaefer
Copy link
Member Author

kkaefer commented Jan 29, 2014

screen shot 2014-01-29 at 12 44 54

@tronical tronical mentioned this issue Jun 13, 2014
Closed
@mb12 mb12 mentioned this issue Oct 29, 2014
Closed
This was referenced Jan 16, 2015
Closed
Closed
@mb12 mb12 mentioned this issue Feb 8, 2015
Closed
This was referenced Mar 25, 2015
Closed
Closed
Closed
@bleege bleege mentioned this issue Mar 26, 2015
Closed
@DangeloID DangeloID mentioned this issue Jul 22, 2015
Closed
@bmeine bmeine mentioned this issue Aug 13, 2015
Closed
@tobrun tobrun mentioned this issue Oct 29, 2015
Closed
@adam-mapbox adam-mapbox mentioned this issue Nov 17, 2015
Closed
@tobrun tobrun mentioned this issue Nov 23, 2015
Closed
@niedzielski niedzielski mentioned this issue Dec 10, 2015
Closed
@Jayroo5245 Jayroo5245 mentioned this issue Feb 24, 2016
Closed
@AlexeyIke AlexeyIke mentioned this issue Mar 24, 2016
Closed
@DucHM DucHM mentioned this issue May 24, 2016
Closed
@tobrun tobrun mentioned this issue Jul 15, 2016
Closed
@Gurbo Gurbo mentioned this issue Jul 30, 2016
Closed
@boundsj boundsj mentioned this issue Aug 12, 2016
Closed
@ASnegoff ASnegoff mentioned this issue Sep 23, 2016
Closed
tmpsantos added a commit that referenced this issue Sep 26, 2016
@tmpsantos
[core] Fix initialization race on util::mapbox::isMapboxURL
3faeba1 
This function can be called from different threads and was depending
on a global `std::string protocol` which can do heap allocations.

The first thread to use it would initialized it which is not exactly
safe, so this patch moves it to a `char *` that is just a pointer to
the data segment, so no races.

Valgrind detected it on #6431.

```
==9874== Conditional jump or move depends on uninitialised value(s)
==9874==    at 0x4C307C2: __memcmp_sse4_1 (in /home/travis/build/mapbox/mapbox-gl-native/mason_packages/linux-x86_64/valgrind/latest/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9874==    by 0x79896E: mbgl::util::mapbox::isMapboxURL(std::string const&) (in /home/travis/build/mapbox/mapbox-gl-native/build/qt-linux-x86_64/Release/mbgl-test)
==9874==    by 0x6DC756: mbgl::style::TileSourceImpl::parseTileJSON(std::string const&, std::string const&, mbgl::SourceType, unsigned short) (in /home/travis/build/mapbox/mapbox-gl-native/build/qt-linux-x86_64/Release/mbgl-test)
==9874==    by 0x6DDA6A: std::_Function_handler<void (mbgl::Response), mbgl::style::TileSourceImpl::loadDescription(mbgl::FileSource&)::{lambda(mbgl::Response)#1}>::_M_invoke(std::_Any_data const&, mbgl::Response&&) (in /home/travis/build/mapbox/mapbox-gl-native/build/qt-linux-x86_64/Release/mbgl-test)
==9874==    by 0x50BE80: std::_Function_handler<void (), mbgl::StubFileSource::StubFileSource()::{lambda()#1}>::_M_invoke(std::_Any_data const&) (in /home/travis/build/mapbox/mapbox-gl-native/build/qt-linux-x86_64/Release/mbgl-test)
==9874==    by 0x70972A5: QMetaObject::activate(QObject*, int, int, void**) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==9874==    by 0x70A3621: QTimer::timerEvent(QTimerEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==9874==    by 0x7098053: QObject::event(QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==9874==    by 0x60CCC8B: QApplicationPrivate::notify_helper(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.2.1)
==9874==    by 0x60D1E55: QApplication::notify(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.2.1)
==9874==    by 0x706FC2C: QCoreApplication::notifyInternal(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==9874==    by 0x70BC1AC: QTimerInfoList::activateTimers() (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==9874==
```
tmpsantos added a commit that referenced this issue Sep 26, 2016
@tmpsantos
[core] Fix initialization race on util::mapbox::isMapboxURL (#6455)
78af55f 
This function can be called from different threads and was depending
on a global `std::string protocol` which can do heap allocations.

The first thread to use it would initialized it which is not exactly
safe, so this patch moves it to a `char *` that is just a pointer to
the data segment, so no races.

Valgrind detected it on #6431.

```
==9874== Conditional jump or move depends on uninitialised value(s)
==9874==    at 0x4C307C2: __memcmp_sse4_1 (in /home/travis/build/mapbox/mapbox-gl-native/mason_packages/linux-x86_64/valgrind/latest/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9874==    by 0x79896E: mbgl::util::mapbox::isMapboxURL(std::string const&) (in /home/travis/build/mapbox/mapbox-gl-native/build/qt-linux-x86_64/Release/mbgl-test)
==9874==    by 0x6DC756: mbgl::style::TileSourceImpl::parseTileJSON(std::string const&, std::string const&, mbgl::SourceType, unsigned short) (in /home/travis/build/mapbox/mapbox-gl-native/build/qt-linux-x86_64/Release/mbgl-test)
==9874==    by 0x6DDA6A: std::_Function_handler<void (mbgl::Response), mbgl::style::TileSourceImpl::loadDescription(mbgl::FileSource&)::{lambda(mbgl::Response)#1}>::_M_invoke(std::_Any_data const&, mbgl::Response&&) (in /home/travis/build/mapbox/mapbox-gl-native/build/qt-linux-x86_64/Release/mbgl-test)
==9874==    by 0x50BE80: std::_Function_handler<void (), mbgl::StubFileSource::StubFileSource()::{lambda()#1}>::_M_invoke(std::_Any_data const&) (in /home/travis/build/mapbox/mapbox-gl-native/build/qt-linux-x86_64/Release/mbgl-test)
==9874==    by 0x70972A5: QMetaObject::activate(QObject*, int, int, void**) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==9874==    by 0x70A3621: QTimer::timerEvent(QTimerEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==9874==    by 0x7098053: QObject::event(QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==9874==    by 0x60CCC8B: QApplicationPrivate::notify_helper(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.2.1)
==9874==    by 0x60D1E55: QApplication::notify(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.2.1)
==9874==    by 0x706FC2C: QCoreApplication::notifyInternal(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==9874==    by 0x70BC1AC: QTimerInfoList::activateTimers() (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==9874==
```
@halset halset mentioned this issue Sep 27, 2016
Closed
@art2limit art2limit mentioned this issue Oct 19, 2016
Closed
@mheins57 mheins57 mentioned this issue Oct 24, 2016
Closed
This was referenced Feb 5, 2019
Closed
Closed
@djavid djavid mentioned this issue Mar 5, 2019
Closed
@technocidal technocidal mentioned this issue Mar 26, 2019
Closed
@CMingTseng CMingTseng mentioned this issue Mar 27, 2019
Closed
friedbunny pushed a commit that referenced this issue Apr 4, 2019
@TimWatson
Merge pull request #1 from mapbox/master
0ff2506 
Merge Master
@Rolf737 Rolf737 mentioned this issue Apr 11, 2019
Closed
@hussi1 hussi1 mentioned this issue Apr 19, 2019
Closed
@whind whind mentioned this issue Apr 23, 2019
Closed
@jimmyjzemoso jimmyjzemoso mentioned this issue May 2, 2019
Closed
@whind whind mentioned this issue May 6, 2019
Closed
@philemonmerlet philemonmerlet mentioned this issue May 15, 2019
Closed
@arthabus arthabus mentioned this issue May 16, 2019
Closed
@jmkiley jmkiley mentioned this issue Jul 1, 2019
Closed
This was referenced Aug 14, 2019
Closed
Closed
@JRWilding JRWilding mentioned this issue Aug 16, 2019
Closed
@dagatsoin dagatsoin mentioned this issue Aug 26, 2019
Closed
@sattarsh sattarsh mentioned this issue Aug 26, 2019
Closed
@vchernetsky vchernetsky mentioned this issue Nov 14, 2019
Closed
@JustinGanzer JustinGanzer mentioned this issue Nov 15, 2019
Open
@tobrun tobrun mentioned this issue Jan 8, 2020
Closed
@Yoni-Reiss Yoni-Reiss mentioned this issue Jan 27, 2020
Closed
@dongbingbin77 dongbingbin77 mentioned this issue Feb 11, 2020
Closed
@pingus-nikalex pingus-nikalex mentioned this issue Mar 4, 2020
Closed
@PhloxDev PhloxDev mentioned this issue Mar 6, 2020
Closed
@AlexanderEggers AlexanderEggers mentioned this issue Mar 6, 2020
Closed
@kjkrum kjkrum mentioned this issue May 29, 2020
Open
@garfberg garfberg mentioned this issue Nov 25, 2020
Open
@adrianstrahan adrianstrahan mentioned this issue Dec 17, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
0.0.0
Development

No branches or pull requests
1 participant
@kkaefer