Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

MGLOpenGLStyleLayer leaks when not added to a map #10771

Closed
asheemmamoowala opened this issue Dec 21, 2017 · 1 comment
Closed

MGLOpenGLStyleLayer leaks when not added to a map #10771

asheemmamoowala opened this issue Dec 21, 2017 · 1 comment
Labels
bug Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS

Comments

@asheemmamoowala
Copy link
Contributor

Carried forward from: #10765 (comment)

An MGLOpenGLStyleLayer is retained by core when created. This should only be done when the layer is added to a map.
@asheemmamoowala asheemmamoowala added Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS labels Dec 21, 2017
@asheemmamoowala asheemmamoowala mentioned this issue Dec 21, 2017
Merged
@1ec5 1ec5 added the bug label Dec 21, 2017
@akitchen akitchen mentioned this issue Jan 9, 2018
Merged
@1ec5 1ec5 mentioned this issue Feb 21, 2018
Closed
akitchen pushed a commit that referenced this issue Feb 23, 2018
Adds failing tests for #10771 and #11143
48918fa 
Unfortunately a brief spin of the run loop is required for the layer reuse test. I've tried to tune this down for my machine; YMMV
@akitchen akitchen mentioned this issue Feb 27, 2018
Closed
@asheemmamoowala asheemmamoowala mentioned this issue Mar 29, 2018
Merged
2 tasks
asheemmamoowala pushed a commit that referenced this issue Mar 30, 2018
Adds failing tests for #10771 and #11143
30ecd0c 
Unfortunately a brief spin of the run loop is required for the layer reuse test. I've tried to tune this down for my machine; YMMV
@asheemmamoowala
Copy link
Contributor Author

Fixed in #11553

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@1ec5 @asheemmamoowala