This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Introduces a test harness for integrated regression tests on iOS #10873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akitchen
added
iOS
akitchen
force-pushed
the
ios-integration-harness
branch
from
59bf34c to
192cae8
Compare
akitchen
force-pushed
the
ios-integration-harness
branch
from
192cae8 to
8f9a48e
Compare
|
Update - now that we've merged the change that brings us on to Circle's macOS image with Xcode 9.2, we're good to start including tests like this one. Thanks @friedbunny ! |
akitchen
removed
the
⚠️ DO NOT MERGE
akitchen
force-pushed
the
ios-integration-harness
branch
2 times, most recently
from
8b96c33 to
0a2a5f2
Compare
|
Going to wait to rebase on top of #10918 |
friedbunny
approved these changes
Jan 16, 2018
|
Looking forward to filling these out and getting rid of the KIF target. 😁 |
added 3 commits
January 19, 2018 14:57
This will allow us to write lightweight integration tests between MGLMapView and the core renderer. Also includes a test for the recent custom layer memory fix, reverting the fix in order to demonstrate the failing test.
Revert this commit to see integration test fail.
akitchen
force-pushed
the
ios-integration-harness
branch
from
0a2a5f2 to
15576a5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new targets in
ios.xcodeproject:Integration Test Harness.appand anintegration.xctestbundle. The former is an empty iOS app providing nothing more than an app delegate and a window, and the latter is a test bundle which contains one integrated test to guard against a potential regression of #10755. In order to write a legitimately failing behavioral test we need to place the map view in a superview within a key window, and it is not possible to make a window key in ourtest.xctestbundle as it does not use an iOS app as its bundle loader.It is my hope that this will help us when it comes time to refactor to address #10771, for example. This can also serve as a starter pattern for writing regression tests against this kind of crash in the future (or at least as a conversation starter). I'm super open to suggestions around organizing/naming this stuff, as well as on this approach in general.
The failure on CI has been narrowed down to an Xcode 9.0 issue. We should hold this back until we're able to move forward to a newer version of Xcode on Circle CI. I also want to tidy up the commit log before merging.
Update: we have moved forward to Xcode 9.2 on CI, and the commit log is tidier now. Should be ready to merge. I'm going to wait to rebase on top of #10918 however.
/cc @friedbunny