Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Replace KIF with XCUITest #4794

Closed
1ec5 opened this issue Apr 22, 2016 · 1 comment
Closed

Replace KIF with XCUITest #4794

1ec5 opened this issue Apr 22, 2016 · 1 comment
Labels
accessibility Integration with screen readers and other assistive technology iOS Mapbox Maps SDK for iOS tests

Comments

@1ec5
Copy link
Contributor

1ec5 commented Apr 22, 2016

We should replace the KIF-based iOS SDK functional tests with similar tests based on XCUITest. The KIF tests have long suffered from unreliability such as #2734. Random failures forced us to disable tests one by one (e.g., #2734, #2769, and #3555) until we finally removed the entire suite from CI in #4594. We’ve had good results so far with the non-UI unit tests added to OS X in #3406 and to iOS in #4641. Hopefully XCUITest will be similarly reliable due to its tighter system integration.

Thanks to improvements in the build system in #4641, it’s quite easy to add a UI test bundle to the iOS project. We can replicate the gesture tests using -[XCUICoordinate pressForDuration:thenDragToCoordinate:] and some UILabels that we continuously update with the map view’s current state. XCUITest operates on accessibility elements, whereas our existing annotation-related tests rely on access to the actual MGLMapView object, so converting them is blocked by #1496.

/cc @friedbunny @boundsj

@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS tests labels Apr 22, 2016
@1ec5 1ec5 added this to the ios-v3.3.0 milestone Apr 22, 2016
@1ec5 1ec5 mentioned this issue Apr 25, 2016
12 tasks
1ec5 added a commit that referenced this issue Apr 27, 2016
Added a UI test bundle that uses XCUITest to test iosapp. The bundle contains some basic tests of annotation functionality. Gather code coverage data in the iosapp and dynamic schemes.

Added accessibility identifiers for key controls in the SDK and iosapp.

Working towards #4794.
1ec5 added a commit that referenced this issue Apr 28, 2016
Added a UI test bundle that uses XCUITest to test iosapp. The bundle contains some basic tests of annotation functionality. Gather code coverage data in the iosapp and dynamic schemes.

Added accessibility identifiers for key controls in the SDK and iosapp.

Working towards #4794.
1ec5 added a commit that referenced this issue May 4, 2016
Added a UI test bundle that uses XCUITest to test iosapp. The bundle contains some basic tests of annotation functionality. Gather code coverage data in the iosapp and dynamic schemes.

Added accessibility identifiers for key controls in the SDK and iosapp.

Working towards #4794.
1ec5 added a commit that referenced this issue May 5, 2016
Added a UI test bundle that uses XCUITest to test iosapp. The bundle contains some basic tests of annotation functionality. Gather code coverage data in the iosapp and dynamic schemes.

Added accessibility identifiers for key controls in the SDK and iosapp.

Working towards #4794.
@friedbunny friedbunny modified the milestones: ios-v3.4.0, ios-v3.3.0 Jun 24, 2016
@boundsj boundsj modified the milestones: ios-v3.4.0, ios-future Jul 11, 2016
@1ec5 1ec5 added the accessibility Integration with screen readers and other assistive technology label Dec 7, 2016
@lilykaiser lilykaiser removed this from the ios-future milestone Nov 15, 2017
@friedbunny
Copy link
Contributor

Though not utilizing XCUITest, #10873 added integration tests that cover this goal.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Integration with screen readers and other assistive technology iOS Mapbox Maps SDK for iOS tests
Projects
None yet
Development

No branches or pull requests

4 participants