Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

move iOS test dependencies & project to CocoaPods #1522

Closed
incanus opened this issue May 12, 2015 · 5 comments
Closed

move iOS test dependencies & project to CocoaPods #1522

incanus opened this issue May 12, 2015 · 5 comments
Labels
build iOS Mapbox Maps SDK for iOS tests

Comments

@incanus
Copy link
Contributor

incanus commented May 12, 2015

Rather than using a combo of submodule (KIF), inline static library (OCMock), and included source (OHHTTPStubs).

Related: #1452, #1517

@incanus incanus added iOS Mapbox Maps SDK for iOS build labels May 12, 2015
@incanus incanus added this to the iOS Beta 2 milestone May 12, 2015
@incanus incanus added the tests label May 14, 2015
jfirebaugh added a commit that referenced this issue May 29, 2015
@jfirebaugh jfirebaugh self-assigned this May 29, 2015
@incanus
Copy link
Contributor Author

incanus commented Jun 15, 2015

@jfirebaugh How are you feeling about the state of this? Probably interrelated with #1452.

@jfirebaugh
Copy link
Contributor

Yeah, I would feel much better about this if #1452 landed first.

@incanus incanus modified the milestones: iOS Beta 2, iOS Beta 3 Jun 17, 2015
jfirebaugh added a commit that referenced this issue Jul 3, 2015
@incanus incanus modified the milestone: iOS Beta 3 Jul 7, 2015
@incanus
Copy link
Contributor Author

incanus commented Sep 2, 2015

I think this is going to require us to integrate Travis & CocoaPods-based install. It may be doable. Another option is to check in the pre-built dependencies directly into version control, but that's going to grow our repo.

Considering we still have the SMCalloutView (plus future iOS dependencies) as submodules, it might not be worth eliminating just this one (KIF) once the npm-related submodules are removed.

@1ec5
Copy link
Contributor

1ec5 commented Apr 22, 2016

KIF will go away as part of #4794. We aren’t currently using either OCMock or OHHTTPStubs, since the telemetry tests were removed long ago (#2822).

@friedbunny
Copy link
Contributor

This doesn’t seem relevant now. If we need to revisit the question of how to install test dependencies, let’s consider other options before settling on CocoaPods.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build iOS Mapbox Maps SDK for iOS tests
Projects
None yet
Development

No branches or pull requests

4 participants